Fix Ruby integration CI #2765
Merged
Fix Ruby integration CI #2765
+141
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
fix-ruby-ci
branch
2 times, most recently
from
75de743 to
0379b2f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2765 +/- ##
==========================================
- Coverage 78.65% 78.54% -0.12%
==========================================
Files 678 678
Lines 116334 115258 -1076
Branches 16312 16314 +2
==========================================
- Hits 91507 90529 -978
+ Misses 24039 23941 -98
Partials 788 788 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Builds expected to fail until the new ecr image is in. |
justsmth
previously approved these changes
Oct 27, 2025
nhatnghiho
reviewed
Oct 29, 2025
| name: Run Container | ||
| with: | ||
| image: ${{ steps.login-ecr.outputs.registry }}/aws-lc/ubuntu:22.04 | ||
| image: ${{ steps.login-ecr.outputs.registry }}/aws-lc/ubuntu-24.04_integration |
There was a problem hiding this comment.
If I'm not mistaken, we migrated Docker image build to GHA. Shouldn't we make use of that?
There was a problem hiding this comment.
Ahh didn't realize that had happened. I'll reuse the stuff over there.
samuel40791765
force-pushed
the
fix-ruby-ci
branch
from
0379b2f to
cd0be89
Compare
skmcgrail
reviewed
Oct 29, 2025
Co-authored-by: Sean McGrail <549813+skmcgrail@users.noreply.github.com>
justsmth
approved these changes
Oct 29, 2025
skmcgrail
approved these changes
Oct 29, 2025
samuel40791765
added a commit
to samuel40791765/aws-lc
that referenced
this pull request
Oct 29, 2025
This reverts commit 693ca26.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
P315730123Description of changes:
Call-outs:
N/A
Testing:
CI
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.