-
Notifications
You must be signed in to change notification settings - Fork 154
Match req CLI behavior with OpenSSL #2836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
- Coverage 78.25% 78.24% -0.02%
==========================================
Files 683 683
Lines 117241 117347 +106
Branches 16484 16487 +3
==========================================
+ Hits 91749 91815 +66
- Misses 24608 24646 +38
- Partials 884 886 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| fprintf(stderr, "Writing private key to %s\n", out_path.c_str()); | ||
| } | ||
|
|
||
| fprintf(stderr, "Writing private key to %s\n", out_path.c_str()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know that out_path will always be non-null/non-empty? looks like prior logic had a default value for this case. should we consider erroring out?
i see we move some of that logic below to L904, but are there any other call sites for WritePrivateKey?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a condition to only call WritePrivateKey when keyout is non-empty
Description of changes:
Some of our current implementation doesn't match the OpenSSL default behavior, resulting in some package failures. The fixes include:
-keyoutis not provided and the config has no default output pathreqsection is found in configTesting:
Cleaned up and added extra tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.