generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 154
Add conversion and traceability for third-party test vectors #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sgmenda-aws
wants to merge
20
commits into
aws:main
Choose a base branch
from
sgmenda-aws:sync-vectors-convert
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 78.24% 78.42% +0.17%
==========================================
Files 683 683
Lines 117346 117347 +1
Branches 16488 16492 +4
==========================================
+ Hits 91821 92032 +211
+ Misses 24641 24428 -213
- Partials 884 887 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses the need to convert third-party test vectors to AWS-LC's file_test.h format and track which vectors are tested. Currently, test vectors are manually converted and there's no systematic way to verify that all vectors in
third_party/are actually used in tests.Description of changes:
Extends the test vector infrastructure from #2811 with two new phases (each can be skipped independently):
convert_vector.py(inspired by the existing Go converter)vectors_spec.mdwith MUST requirements and uses duvet to verify that test files contain corresponding annotationsConverts and integrates
aes_gcm_testfrom the latest upstream Wycheproof as a proof of concept, the test and duvet verification pass.Call-outs:
util/convert_wycheproof/will be removed once all test vectors are migrated to the new systemaes_gcm_testvector inthird_party/wycheproof_testvectors/Testing:
convert_vector.pyverify JSON to file_test.h conversioncrypto/cipher_extra/aead_test.ccRun the full workflow with
cd third_party/vectors && ./sync.py.Run the migrated test with
cd build && ./crypto/crypto_test --gtest_filter="AEADTest.WycheproofAESGCM"By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.