Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Jan 24, 2024

Description of changes

  • Upgrade NICE DCV to 2023.1-16388

Tests

  • System tests in this PR
  • Create AMI and Run Integ tests test_dcv_with_remote_access and test_dcv_configuration [PASSED]
./kitchen.ec2.sh platform-install test dcv
./kitchen.ec2.sh  platform-config test dcv

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 added the 3.x label Jan 24, 2024
@himani2411 himani2411 requested review from a team as code owners January 24, 2024 20:32
@codecov
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d85a09c) 76.48% compared to head (44a2444) 76.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2622   +/-   ##
========================================
  Coverage    76.48%   76.48%           
========================================
  Files           22       22           
  Lines         2220     2220           
========================================
  Hits          1698     1698           
  Misses         522      522           
Flag Coverage Δ
unittests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 force-pushed the develop branch 3 times, most recently from a5dc3fd to b683a12 Compare January 24, 2024 21:48
@enrico-usai
Copy link
Contributor

Can you add in the description the result of the execution of:

kitchen.ec2.sh environment-install test dcv
kitchen.ec2.sh environment-config test dcv

@himani2411 himani2411 force-pushed the develop branch 3 times, most recently from 2ccb433 to ba8a945 Compare February 13, 2024 18:31
hanwen-pcluste
hanwen-pcluste previously approved these changes Feb 13, 2024
@himani2411 himani2411 merged commit 51b2ec1 into aws:develop Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants