Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 9, 2024

Description of changes

  • Invoking sudo_access from Platform cookbook when updating cluster

Tests

  • Passed Integ tests
    * create:test_create.py::test_create_disable_sudo_access_for_default_user
    * test_build_image ( failure for Stack deletion unrelated to this commit)

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a37905) 76.37% compared to head (79f66b5) 76.37%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2646   +/-   ##
========================================
  Coverage    76.37%   76.37%           
========================================
  Files           22       22           
  Lines         2248     2248           
========================================
  Hits          1717     1717           
  Misses         531      531           
Flag Coverage Δ
unittests 76.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 enabled auto-merge (squash) February 9, 2024 16:43
@himani2411 himani2411 changed the title [Disable Sudo] Invoking sudo_access from Slurm cookbook when updating cluster [Disable Sudo] Invoking sudo_access from Platform cookbook when updating cluster Feb 12, 2024
@himani2411 himani2411 force-pushed the develop-sudo-pr branch 6 times, most recently from 604dc91 to b1dfcba Compare February 12, 2024 21:15
@himani2411 himani2411 merged commit e4fee1f into aws:develop Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants