Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 12, 2024

Description of changes

  • Pinning NVIDIA version for Centos7 to 535.129.03

Tests

  • Created an AMI for centos7 and Alinux2 then ran
  • ./kitchen.ec2.sh platform-config test nvidia-gdrcopy-centos7
  • ./kitchen.ec2.sh platform-config test nvidia-gdrcopy-alinux2

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c4ced0) 76.37% compared to head (b210f5c) 76.37%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2648   +/-   ##
========================================
  Coverage    76.37%   76.37%           
========================================
  Files           22       22           
  Lines         2248     2248           
========================================
  Hits          1717     1717           
  Misses         531      531           
Flag Coverage Δ
unittests 76.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 force-pushed the centos7-nvidia branch 2 times, most recently from 6092e50 to 095c358 Compare February 12, 2024 22:43
@himani2411 himani2411 enabled auto-merge (squash) February 13, 2024 00:12
@himani2411 himani2411 merged commit 7a37905 into aws:develop Feb 13, 2024
hanwen-pcluste pushed a commit to hanwen-pcluste/aws-parallelcluster-cookbook that referenced this pull request Feb 17, 2024
hanwen-pcluste pushed a commit to hanwen-pcluste/aws-parallelcluster-cookbook that referenced this pull request Feb 17, 2024
hanwen-pcluste pushed a commit that referenced this pull request Feb 19, 2024
himani2411 pushed a commit to himani2411/aws-parallelcluster-cookbook that referenced this pull request Feb 19, 2024
himani2411 added a commit that referenced this pull request Feb 19, 2024
…ttributes (#2657)

* [Dependencies] Overriding the NVIDIA version for Centos7 using node_attributes

* Revert "[kitchen tests] Fix pinning NVIDIA version for Centos7 to 535.129.03 (#2648)"

This reverts commit 295f44c.

---------

Co-authored-by: Himani Deshpande <himanidp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants