Skip to content

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Feb 13, 2024

Description of changes

  • Update PMIX to 4.2.9
  • Using Attributes so that we can use them through ExtraChefAttributes if required

Tests

Created AMI's and tested
./kitchen.ec2.sh slurm-install test pmix -c 5
./kitchen.ec2.sh slurm-install test slurm -c 5

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c75a58) 76.48% compared to head (73663d1) 76.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2650   +/-   ##
========================================
  Coverage    76.48%   76.48%           
========================================
  Files           22       22           
  Lines         2220     2220           
========================================
  Hits          1698     1698           
  Misses         522      522           
Flag Coverage Δ
unittests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himani2411 himani2411 enabled auto-merge (squash) February 14, 2024 16:37
@himani2411 himani2411 merged commit 44f3a0a into aws:develop Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants