Skip to content

[Dependencies] Overriding the NVIDIA version for Centos7 using node_attributes #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2024
Merged

[Dependencies] Overriding the NVIDIA version for Centos7 using node_attributes #2657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7499765
[Dependencies] Overriding the NVIDIA version for Centos7 using node_a…
Feb 19, 2024
350d18a
Revert "[kitchen tests] Fix pinning NVIDIA version for Centos7 to 535…
Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...oks/aws-parallelcluster-platform/resources/nvidia_driver/partial/_nvidia_driver_common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@
return unless nvidia_driver_enabled?
return if on_docker?

# Share nvidia driver version with InSpec tests
node.default['cluster']['nvidia']['driver_version'] = _nvidia_driver_version
node_attributes "Save Nvidia driver version for Inspec tests"

remote_file tmp_nvidia_run do
source nvidia_driver_url
mode '0755'
Expand Down
4 changes: 4 additions & 0 deletions cookbooks/aws-parallelcluster-platform/spec/unit/resources/nvidia_driver_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,10 @@ def self.setup(chef_run, nvidia_driver_version: nil)
end
cached(:node) { chef_run.node }

it 'dumps nodes attribues' do
is_expected.to write_node_attributes('Save Nvidia driver version for Inspec tests')
end

it 'sets up nvidia_driver' do
is_expected.to setup_nvidia_driver('setup')
end
Expand Down
6 changes: 1 addition & 5 deletions cookbooks/aws-parallelcluster-platform/test/controls/nvidia_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,7 @@
(node['cluster']['nvidia']['enabled'] == 'yes' || node['cluster']['nvidia']['enabled'] == true)
end

expected_nvidia_driver_version = if os_properties.centos7?
'535.129.03'
else
node['cluster']['nvidia']['driver_version']
end
expected_nvidia_driver_version = node['cluster']['nvidia']['driver_version']
expected_nvidia_kernel_license = 'Dual MIT/GPL'
expected_nvidia_kernel_module = "NVRM version: NVIDIA UNIX Open Kernel Module"

Expand Down