Skip to content

Conversation

@dreambeyondorange
Copy link
Contributor

… in the efs resource

Updates to a cluster result in boolean values for the iam_authorization and efs_encryption_in_transit objects.

Tests

  • Tested the change locally with an update to a cluster with an EFS fs with encryption in transit. Adding the boolean check allows the cookbook to use TLS for the fs.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.48%. Comparing base (7d414fe) to head (6594f79).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2691   +/-   ##
========================================
  Coverage    76.48%   76.48%           
========================================
  Files           22       22           
  Lines         2220     2220           
========================================
  Hits          1698     1698           
  Misses         522      522           
Flag Coverage Δ
unittests 76.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dreambeyondorange dreambeyondorange force-pushed the efs-encrypt branch 2 times, most recently from f00c755 to e69dc1e Compare April 5, 2024 12:49
@dreambeyondorange dreambeyondorange changed the title Add boolean check in addition to the string true for _mount_unmount… Force a string true in the update_shared_storages to match the expectations of _mount_unmount Apr 5, 2024
…ount in the efs resource

Updates to a cluster result in boolean values for the iam_authorization and efs_encryption_in_transit variables when the
mapping yaml file is loaded.  Need to force strings to be consistent with the dna.json pattern.
@dreambeyondorange dreambeyondorange merged commit c06a394 into aws:develop Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants