[ADC Build Image] Add support for build image in ADC #2781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+27
to
+31
| if aws_region.start_with?("us-iso") | ||
| %w(libibverbs-utils librdmacm-utils) | ||
| else | ||
| %w(environment-modules libibverbs-utils librdmacm-utils) | ||
| end |
Contributor
There was a problem hiding this comment.
Why is environment-modules removed?
Contributor
Author
There was a problem hiding this comment.
same reasoning as the other comment I left
Comment on lines
+30
to
+32
| %w(dkms rpm-build make check check-devel) | ||
| else | ||
| %w(dkms rpm-build make check check-devel subunit subunit-devel) |
Contributor
There was a problem hiding this comment.
Why some is removed?
Contributor
Author
There was a problem hiding this comment.
those are not available in ADC regions, so they are downloaded in install_packages through the epel_deps.tar.gz artifiact.
hgreebe
force-pushed
the
adc-release-3.10
branch
2 times, most recently
from
a0dfdd3 to
5b349be
Compare
hgreebe
force-pushed
the
adc-release-3.10
branch
from
5b349be to
05b9c18
Compare
hanwen-pcluste
approved these changes
Jul 25, 2024
hgreebe
added a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Sep 5, 2024
* [ADC Build Image] Get build dependencies through awscli * [ADC Build Image] Disable epel repo for alinux2 * [ADC Build Image] Install missing yum dependencies from s3 * [ADC Build Image] Get dependencies using https * [ADC Build Image] Patch AWS_CA_BUNDLE * [ADC Build Image] Include differing paths for iso regions * [ADC Build Image] Update changelog --------- Co-authored-by: Hanwen <68928867+hanwen-pcluste@users.noreply.github.com> Signed-off-by: Helena Greebe <hgreebe@amazon.com>
hgreebe
added a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Sep 5, 2024
* [ADC Build Image] Get build dependencies through awscli * [ADC Build Image] Disable epel repo for alinux2 * [ADC Build Image] Install missing yum dependencies from s3 * [ADC Build Image] Get dependencies using https * [ADC Build Image] Patch AWS_CA_BUNDLE * [ADC Build Image] Include differing paths for iso regions * [ADC Build Image] Update changelog --------- Co-authored-by: Hanwen <68928867+hanwen-pcluste@users.noreply.github.com> Signed-off-by: Helena Greebe <hgreebe@amazon.com>
hgreebe
added a commit
to hgreebe/aws-parallelcluster-cookbook
that referenced
this pull request
Sep 5, 2024
* [ADC Build Image] Get build dependencies through awscli * [ADC Build Image] Disable epel repo for alinux2 * [ADC Build Image] Install missing yum dependencies from s3 * [ADC Build Image] Get dependencies using https * [ADC Build Image] Patch AWS_CA_BUNDLE * [ADC Build Image] Include differing paths for iso regions * [ADC Build Image] Update changelog --------- Co-authored-by: Hanwen <68928867+hanwen-pcluste@users.noreply.github.com> Signed-off-by: Helena Greebe <hgreebe@amazon.com>
hgreebe
added a commit
that referenced
this pull request
Sep 6, 2024
* [ADC Build Image] Get build dependencies through awscli * [ADC Build Image] Disable epel repo for alinux2 * [ADC Build Image] Install missing yum dependencies from s3 * [ADC Build Image] Get dependencies using https * [ADC Build Image] Patch AWS_CA_BUNDLE * [ADC Build Image] Include differing paths for iso regions * [ADC Build Image] Update changelog --------- Signed-off-by: Helena Greebe <hgreebe@amazon.com> Co-authored-by: Hanwen <68928867+hanwen-pcluste@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.