Skip to content

Conversation

@gmarciani
Copy link
Contributor

Description of changes

Address Shellcheck finding 'SC2155 in iso-ca-bundle-config.sh': _token variable is now declared and assigned separately to avoid masking return values.

Tests

Shellcheck success.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…g.sh': _token variable is now declared and assigned separately to avoid masking return values.

Signed-off-by: Giacomo Marciani <mgiacomo@amazon.com>
@gmarciani gmarciani merged commit e87af87 into aws:release-3.11 Oct 15, 2024
37 of 39 checks passed
@gmarciani gmarciani deleted the wip/mgiacomo/3.11.1/shellcheck-fix-1015-1 branch October 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants