Clean Resolv.conf in official AMI build #2920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Only cleanup resolv conf during official AMI build. In the future, we will evaluate to apply this improvement to all AMI builds. 2. Also clean up `/run/systemd/resolve/resolv.conf `. This file exists on Ubuntu Signed-off-by: Hanwen <hanwenli@amazon.com>
gmarciani
reviewed
Mar 21, 2025
| rm -f /etc/sysconfig/network-scripts/ifcfg-eth0 | ||
| fi | ||
|
|
||
| # Clean resolv.conf if it's not managed by system |
Contributor
There was a problem hiding this comment.
could you please align this comment to the current strategy and put a short explanation, so that we will not forget i future?
gmarciani
approved these changes
Mar 21, 2025
hanwen-cluster
added a commit
to hanwen-cluster/aws-parallelcluster
that referenced
this pull request
Mar 24, 2025
The boot speed of Rocky and RHEL were improved after aws/aws-parallelcluster-cookbook#2920 Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-cluster
added a commit
to aws/aws-parallelcluster
that referenced
this pull request
Mar 24, 2025
The boot speed of Rocky and RHEL were improved after aws/aws-parallelcluster-cookbook#2920 Signed-off-by: Hanwen <hanwenli@amazon.com>
himani2411
pushed a commit
to himani2411/aws-parallelcluster
that referenced
this pull request
Apr 2, 2025
The boot speed of Rocky and RHEL were improved after aws/aws-parallelcluster-cookbook#2920 Signed-off-by: Hanwen <hanwenli@amazon.com>
himani2411
pushed a commit
to aws/aws-parallelcluster
that referenced
this pull request
Apr 3, 2025
The boot speed of Rocky and RHEL were improved after aws/aws-parallelcluster-cookbook#2920 Signed-off-by: Hanwen <hanwenli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup of #2919
/run/systemd/resolve/resolv.conf. This file exists on UbuntuTests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.