Skip to content

Conversation

@gmarciani
Copy link
Contributor

Description of changes

This reverts commit cc2aeb2.
We verified that this fix does not solve the issue. even if compute node uses the systemctl poweroff --force with the sudo permissions, there are still cases where the compute node with broken network interface is unable to self terminate.

This bug fix was a nice to have for the patch release, so better to revert.

Tests

  • schedulers.test_slurm.test_error_handling failed due to compute node being stuck in self termination.

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ubuntu24 self termination issue (aws#2959)"

This reverts commit cc2aeb2.
@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.50%. Comparing base (98c689e) to head (84bceee).
Report is 32 commits behind head on release-3.13.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-3.13    #2964   +/-   ##
=============================================
  Coverage         75.50%   75.50%           
=============================================
  Files                23       23           
  Lines              2356     2356           
=============================================
  Hits               1779     1779           
  Misses              577      577           
Flag Coverage Δ
unittests 75.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmarciani gmarciani merged commit f4e398d into aws:release-3.13 May 28, 2025
28 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants