[IMEX] Remove unnecessary condition to skip creation of main and nodes config file. #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
force-pushed
the
wip/mgiacomo/3140/fix-queue-updated-condition-0812-1
branch
from
db0610f to
bc75f4c
Compare
himani2411
reviewed
Aug 12, 2025
cookbooks/aws-parallelcluster-platform/resources/nvidia_imex/partial/_nvidia_imex_common.rb
Show resolved
Hide resolved
gmarciani
force-pushed
the
wip/mgiacomo/3140/fix-queue-updated-condition-0812-1
branch
from
bc75f4c to
936b7bf
Compare
himani2411
previously approved these changes
Aug 12, 2025
gmarciani
force-pushed
the
wip/mgiacomo/3140/fix-queue-updated-condition-0812-1
branch
from
936b7bf to
9e840e1
Compare
himani2411
approved these changes
Aug 12, 2025
gmarciani
deleted the
wip/mgiacomo/3140/fix-queue-updated-condition-0812-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove unnecessary condition to skip creation of main and nodes config file.
We figured out there is no reason to skip the configuration of IMEX config file when queues are updated.
The only relevant condition is to skip it when the files are already created because we do not want to overwrite configurations made by the user (or by an automation) on cluster create/update.
Tests
test_gb200By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.