Skip to content

Conversation

@hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Sep 2, 2025

Description of changes

  • Address formatting/wording issue in 3.14.0 cookbook Changelog

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added the 3.x label Sep 2, 2025
@hehe7318 hehe7318 requested review from a team as code owners September 2, 2025 15:31
CHANGELOG.md Outdated

**ENHANCEMENTS**
- Remove UnkillableStepTimeout from slurm.conf and let slurm set this value.
- Add support for p6e-gb200 instances via capacity blocks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Major] The support does not work out of the box, as it requires some extra steps that are supposed to be done by the user on the image/cluster, e.g. automated configuration of nvidia-imex.

If we are sure we want to surface this support, we must clarify the limitations, such as lack of automated configuration. of nvidia-imex and lack of support for AL2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.20%. Comparing base (a2651f4) to head (7fa27fd).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3017   +/-   ##
========================================
  Coverage    75.20%   75.20%           
========================================
  Files           24       24           
  Lines         2444     2444           
========================================
  Hits          1838     1838           
  Misses         606      606           
Flag Coverage Δ
unittests 75.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hehe7318 hehe7318 enabled auto-merge (squash) September 5, 2025 20:29
@hehe7318 hehe7318 merged commit 921f2d8 into aws:develop Sep 5, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants