Remove usage of temporary file to read computemgtd config #422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #422 +/- ##
===========================================
- Coverage 81.59% 81.57% -0.03%
===========================================
Files 12 12
Lines 1733 1731 -2
===========================================
- Hits 1414 1412 -2
Misses 319 319
Continue to review full report at Codecov.
|
charlesg3
previously approved these changes
Jun 29, 2022
enrico-usai
reviewed
Jun 29, 2022
CHANGELOG.md
Outdated
|
|
||
| **BUG FIXES** | ||
| - Handle corner case in the scaling logic when instance is just launched and the describe instances API doesn't report yet all the EC2 info. | ||
| - Fix file handle leak in computemgtd |
Contributor
There was a problem hiding this comment.
minor: code syntax for: computemgtd
Signed-off-by: Francesco De Martino <fdm@amazon.com>
demartinofra
force-pushed
the
computemgtd-fix
branch
from
b1d1652 to
63db8ee
Compare
enrico-usai
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Following up on the file handler leak fix from #421, I completely removed the dependency on the temporary file in computemgtd.
Tests
References
#421
Checklist
Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.