Skip to content

Conversation

@mendaomn
Copy link
Contributor

Description

This PR sparks from issues related to the fact that the selected KeyPair does not get cleared correctly when a new region is selected.

In order to fix this, and many other issues, the wizard state is re-initialized when a new region is selected.

Changes

  • re-initialize wizard state when a new region is selected
  • move keypair selection from the Cluster section to the HeadNode section

How Has This Been Tested?

  • manually:
    • dry-run with a specific key-pair selected (passes)
    • go back and change region
    • leave key-pair as is (None, in this case)
    • dry-run passes again

PR Quality Checklist

  • I added tests to new or existing code
  • I removed hardcoded strings and used react-i18next library (useTranslation hook and/or Trans component), see an example here
  • I made sure no sensitive info gets logged at any time in the codebase (see here) (e.g. no user info or details, no stacktraces, etc.)
  • I checked that infrastructure/update_infrastructure.sh runs without any error
  • I checked that npm run build builds without any error
  • I checked that clusters are listed correctly
  • I checked that a new cluster can be created (config is produced and dry run passes)
  • I checked that login and logout work as expected

In order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@mendaomn mendaomn merged commit 7796df5 into main Feb 10, 2023
@mendaomn mendaomn deleted the fix-keypairs branch February 10, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants