-
Notifications
You must be signed in to change notification settings - Fork 314
Merge Release 2.4.0 #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge Release 2.4.0 #1128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add possibility to generate AMI list from local cloudformation template and region list passed as input parameters The script will generate amis.txt and a new cloudformation template as usual Signed-off-by: Luca Carrogu <carrogu@amazon.com>
The latest release 0.18.0 re-opened the bug: aws-cloudformation/cfn-lint#564 Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
I had an OSError, Invalid argument, because node.nodeid was: tests_outputs/.../test_slurm.py::test_slurm[c5.xlarge-us-west-1-alinux-slurm].config instead node.name is: tests_outputs/.../test_slurm[c5.xlarge-us-west-1-alinux-slurm].config Doc: https://docs.pytest.org/en/latest/_modules/_pytest/nodes.html Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
The test tries to change the max_queue and verifies the value after the update command. Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Enrico Usai <usai@amazon.com>
They just released the 1.18.1 version that fixes the aws-cloudformation/cfn-lint#564 Signed-off-by: Enrico Usai <usai@amazon.com>
It was failing with: botocore.exceptions.NoRegionError: You must specify a region. Signed-off-by: Enrico Usai <usai@amazon.com>
The configuration option `use_public_ips = true`, is used to toggle allocation of elastic ip's. Many customers don't want to have to use an elastic ip, but they still want too ssh into their instance. This patch allows users to `pcluster ssh cluster` when `use_public_ips = false`. Signed-off-by: Sean Smith <seaam@amazon.com>
+ document how to identify master/compute in pre/post-install scripts + extend the example to use the post_install_args parameter + add a paragraph to specify where to find the output Signed-off-by: Enrico Usai <usai@amazon.com>
This reverts commit dc1b592. Signed-off-by: Francesco De Martino <fdm@amazon.com>
…te node Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
+ add instance fixture to be able to skip the test if the instance is not available (e.g. specific partition) + use eu-west-1 region to avoid to overload the us-west-1 Signed-off-by: Enrico Usai <usai@amazon.com>
… config node.nodeid is: tests_outputs/.../test_slurm.py::test_slurm[c5.xlarge-us-west-1-alinux-slurm].config instead node.name is: tests_outputs/.../test_slurm[c5.xlarge-us-west-1-alinux-slurm].config We changed it to node.name in a previous commit because the "::" characters was a problem for gitbash (windows): (OSError, Invalid argument) Now we are restoring the node_id by replacing the bad characters because the node_id contains both the test file name (test_slurm.py) and the test name (test_slurm), so the configuration file name is unique. Signed-off-by: Enrico Usai <usai@amazon.com>
The idea is to give the factory the power to create and destroy the clusters, but let the Cluster the power to manage itself. Signed-off-by: Enrico Usai <usai@amazon.com>
- Rename PclusterConfig to PClusterConfig - Use dimensions in place of markers - Remove unused instance_ids variable Signed-off-by: Enrico Usai <usai@amazon.com>
Signed-off-by: Luca Carrogu <carrogu@amazon.com>
FSx Lustre not available in eu-central-1 Signed-off-by: Francesco De Martino <fdm@amazon.com>
Build Number 78 aws-parallelcluster-cookbook Git hash: 52e9500e95896640f0b1892445d5a65ff627d410 aws-parallelcluster-node Git hash: 0581c019cb07650f936c2f0305e10287a26aab0b Signed-off-by: ParallelCluster AMI bot <ec2-ds9-dev@amazon.com>
This mitigates failures due to resources not available in randomly picked AZs. Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
* Validate EFA Parameters Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
…ty node termination with running job Signed-off-by: Francesco De Martino <fdm@amazon.com>
…lers Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
This allow a better redistribution of tests across the workers Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Luca Carrogu <carrogu@amazon.com>
related to: aws/aws-parallelcluster-node#151 Signed-off-by: Francesco De Martino <fdm@amazon.com>
Add environment variable override, `AWS_PARALLELCLUSTER_CONFIG_FILE`, for default configuration file location. Intended as an analogy to the standard `AWS_SHARED_CREDENTIALS_FILE`, allowing environment-based specification of a parallelcluster target configuration. Minor update to Configuration doc section to clarify configuration file options.
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
* `--vpc-cluster` allows re-use of the vpc cluster between tests * `--cluster` allows re-use of the cluster between tests * `--no-delete` makes it easy to not delete created cluster, and re-use them Signed-off-by: Sean Smith <seaam@amazon.com>
…_FILE Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Sean Smith <seaam@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Signed-off-by: Francesco De Martino <fdm@amazon.com>
Build Number 155 aws-parallelcluster-cookbook Git hash: 4afb7d672118aa192dd546b18ee4fcc4452e978d aws-parallelcluster-node Git hash: 9db8e2ec25e2fc2314771cee92ebb29b78bdca0f Signed-off-by: ParallelCluster AMI bot <ec2-ds9-dev@amazon.com>
The new tag contains the EFA property Signed-off-by: Luca Carrogu <carrogu@amazon.com>
sean-smith
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.