Please allow more characters in KeyName #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougalb
added a commit
that referenced
this pull request
Oct 6, 2014
Please allow more characters in KeyName
Contributor
|
Thanks. It is merged. Can you please submit future pull requests to the develop branch. |
Contributor
Author
|
For sure. Thanks for merging this, Dougal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my EC2 keys have names that are like e-mail addresses, like:
jwm+ec2-foo@example.com
so I can easily keep track of the different keys I use for various services. The CloudFormation template doesn't allow [+.@], but it seems (after an admittedly quick glance at the code) that allowing those characters shouldn't be a problem.