Add integration test for cluster creation in private subnet #2058
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2058 +/- ##
========================================
Coverage 59.91% 59.91%
========================================
Files 39 39
Lines 5620 5620
========================================
Hits 3367 3367
Misses 2253 2253 Continue to review full report at Codecov.
|
| from assertpy import assert_that | ||
|
|
||
|
|
||
| @pytest.mark.dimensions("eu-west-1", "c4.xlarge", "alinux2", "slurm") |
There was a problem hiding this comment.
let's use c5.xlarge only. I think we use c4 only in cn regions.
There was a problem hiding this comment.
I think eu-west-1 regions is heavily used already. Shall we pick a region with fewer tests?
also we could select centos7 with one of the schedulers.
| compute_instance_type = {{ instance }} | ||
| initial_queue_size = 1 | ||
| max_queue_size = 1 | ||
| maintain_initial_size = true |
There was a problem hiding this comment.
let's set this to false so that in case of slurm we have the bootstrap logic submit a job to the scheduler (this happens only when initial_size > min_size ==> maintain_initial_size = false)
|
|
||
| @pytest.mark.dimensions("eu-west-1", "c4.xlarge", "alinux2", "slurm") | ||
| @pytest.mark.dimensions("eu-west-2", "c5.xlarge", "alinux2", "sge") | ||
| @pytest.mark.usefixtures("scheduler, os, region, test_datadir") |
There was a problem hiding this comment.
why test_datadir in the usefixtures? can't it be removed?
you also need to add instance to the fixtures.
There was a problem hiding this comment.
Test_datadir is needed from pcluster_config_reader, isn't it?
There was a problem hiding this comment.
yes but pcluster_config_reader will get the fixture regardless of it
ddeidda
force-pushed
the
wip/pvt_nw_test
branch
6 times, most recently
from
990c603 to
7c692ef
Compare
Signed-off-by: ddeidda <ddeidda@amazon.com>
ddeidda
force-pushed
the
wip/pvt_nw_test
branch
from
7c692ef to
ec0eca2
Compare
2 participants
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.