integ-tests: test using existing EFS (efs_fs_id) #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-pcluste
added
the
skip-changelog-update
hanwen-pcluste
force-pushed
the
testefs
branch
2 times, most recently
from
6694aef to
64433c0
Compare
yuleiwan
reviewed
Nov 11, 2020
Codecov Report
@@ Coverage Diff @@
## develop #2213 +/- ##
========================================
Coverage 62.02% 62.02%
========================================
Files 40 40
Lines 6131 6131
========================================
Hits 3803 3803
Misses 2328 2328 Continue to review full report at Codecov.
|
hanwen-pcluste
force-pushed
the
testefs
branch
4 times, most recently
from
11ec209 to
c7578ca
Compare
hanwen-pcluste
force-pushed
the
testefs
branch
from
c7578ca to
13685bd
Compare
enrico-usai
reviewed
Nov 27, 2020
| write_file_template = Template() | ||
| write_file_template.set_version("2010-09-09") | ||
| write_file_template.set_description("Stack to write a file to the existing EFS") | ||
| default_security_group_id = ( |
Contributor
There was a problem hiding this comment.
minor: default_security_group --> efs_security_group
hanwen-pcluste
force-pushed
the
testefs
branch
from
13685bd to
80b9345
Compare
hanwen-pcluste
force-pushed
the
testefs
branch
2 times, most recently
from
2dabef0 to
d960539
Compare
enrico-usai
reviewed
Nov 30, 2020
This test uses `troposphere` to create cloudformation stacks for `efs`, `mount target`, and a instance to write an empty file with random name into the efs. Then the test verifies when the existing `efs` is provided through `efs_fs_id` in `pcluster` config file, the cluster created can read the randomly named file and share files between head node and compute node. Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
testefs
branch
from
d960539 to
8c22df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test uses
troposphereto create cloudformation stacks forefs,mount target, and a instance to write an empty file with random name into the efs. Then the test verifies when the existingefsis provided throughefs_fs_idinpclusterconfig file, the cluster created can read the randomly named file and share files between head node and compute node.Signed-off-by: Hanwen hanwenli@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.