integ-tests: test FSx deployment types #2233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuleiwan
added
the
skip-changelog-update
Codecov Report
@@ Coverage Diff @@
## develop #2233 +/- ##
===========================================
+ Coverage 61.80% 61.81% +0.01%
===========================================
Files 39 39
Lines 6061 6060 -1
===========================================
Hits 3746 3746
+ Misses 2315 2314 -1
Continue to review full report at Codecov.
|
yuleiwan
changed the title
yuleiwan
force-pushed
the
text/Fsx_deployment_type
branch
from
4fb3680 to
979d881
Compare
enrico-usai
reviewed
Nov 19, 2020
Contributor
enrico-usai
left a comment
enrico-usai
left a comment
There was a problem hiding this comment.
From what we understand we were already testing all the deployment_types (through test_fsx_lustre_configuration_options) but we weren't checking if the value was correct. Right?
If so let's add this description in the PR.
yuleiwan
force-pushed
the
text/Fsx_deployment_type
branch
2 times, most recently
from
35dfa9a to
ae2e663
Compare
* This test is to verify FSx file system launched by pcluster has the correct deployment type as user set in pcluster config file. * FSx file system has three deployment types in commercial regions SCRATCH_1(dafault), SCRATCH_2, PERSISTENT_1 Signed-off-by: Yulei Wang <yuleiwan@amazon.com>
yuleiwan
force-pushed
the
text/Fsx_deployment_type
branch
from
ae2e663 to
9da584a
Compare
enrico-usai
approved these changes
Nov 20, 2020
Contributor
enrico-usai
left a comment
enrico-usai
left a comment
There was a problem hiding this comment.
Great job! Thanks!
If tested feel free to merge it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yulei Wang yuleiwan@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.