integ-tests: test security groups are properly applied to a cluster #2234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-pcluste
added
the
skip-changelog-update
hanwen-pcluste
force-pushed
the
testsg
branch
from
aa7fc8f to
af3461e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2234 +/- ##
========================================
Coverage 61.88% 61.88%
========================================
Files 40 40
Lines 6106 6106
========================================
Hits 3779 3779
Misses 2327 2327 Continue to review full report at Codecov.
|
hanwen-pcluste
force-pushed
the
testsg
branch
2 times, most recently
from
e4dfb59 to
17f2f86
Compare
Contributor
demartinofra
left a comment
demartinofra
left a comment
There was a problem hiding this comment.
Well done! LGTM. Only dropped a few minor comments
tests/integration-tests/tests/networking/test_security_groups.py
Outdated
Show resolved
Hide resolved
...ts/tests/networking/test_security_groups/test_additional_sg_and_ssh_from/pcluster.config.ini
Show resolved
Hide resolved
tests/integration-tests/tests/networking/test_security_groups.py
Outdated
Show resolved
Hide resolved
hanwen-pcluste
force-pushed
the
testsg
branch
2 times, most recently
from
909ac5a to
1513d2e
Compare
demartinofra
previously approved these changes
Nov 20, 2020
1. Test `additional_sg` in the config file is added to head and compute nodes 2. Test `ssh_from` in the config file applies to the pcluster security group of the head node 3. Test `vpc_security_group_id` in the config file overwrites security group of head and compute nodes, FSx, and EFS Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
testsg
branch
from
1513d2e to
01cbf63
Compare
| {% filter indent(2) %} | ||
| {% include 'common/common.yaml' %} | ||
| {% endfilter %} | ||
| networking: |
Contributor
There was a problem hiding this comment.
let's add the new tests in common.yaml unless we want to exclude them from release tests
…into testsg � Conflicts: � tests/integration-tests/configs/develop.yaml Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
testsg
branch
from
01cbf63 to
d153872
Compare
demartinofra
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additional_sgin the config file is added to head and compute nodesssh_fromin the config file applies to the pcluster security group of the head nodevpc_security_group_idin the config file overwrites security group of head and compute nodes, FSx, and EFSSigned-off-by: Hanwen hanwenli@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.