Set default instance type to free tier instance type #2254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2254 +/- ##
===========================================
+ Coverage 61.97% 62.12% +0.14%
===========================================
Files 40 40
Lines 6123 6149 +26
===========================================
+ Hits 3795 3820 +25
- Misses 2328 2329 +1
Continue to review full report at Codecov.
|
hanwen-pcluste
force-pushed
the
defaultinstancetype
branch
8 times, most recently
from
7148aa1 to
3a66c3e
Compare
ddeidda
reviewed
Nov 25, 2020
enrico-usai
reviewed
Nov 25, 2020
hanwen-pcluste
force-pushed
the
defaultinstancetype
branch
2 times, most recently
from
9d90125 to
71ee72d
Compare
ddeidda
reviewed
Dec 1, 2020
Contributor
ddeidda
left a comment
ddeidda
left a comment
There was a problem hiding this comment.
We are close! Let's talk about the few open points 👍
|
|
||
| def refresh(self): | ||
| """Get default value from a boto3 call for free tier instance type.""" | ||
| if not self.value: |
Contributor
There was a problem hiding this comment.
What about a shorter syntax like this:
self.value = get_default_instance_type() if pcluster_config.get_section("cluster").get_param_value("scheduler") != "awsbatch" else "optimal"
a29b46a to
0bba355
Compare
When running pcluster in a region with free tier, default instance type is set to the free tier instance type. When running pcluster in the China (BJS) region or AWS GovCloud (US) regions, default instance type is t3.micro. Free tier is not available in the China (BJS) region and AWS GovCloud (US) regions. For more information about free tier, please see https://aws.amazon.com/free/free-tier-faqs/ Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
defaultinstancetype
branch
2 times, most recently
from
92f1e32 to
672e15a
Compare
…into defaultinstancetype � Conflicts: � CHANGELOG.md � cli/src/pcluster/config/mappings.py � cli/src/pcluster/configure/easyconfig.py � cli/src/pcluster/examples/config � tests/integration-tests/tests/configure/test_pcluster_configure.py Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
defaultinstancetype
branch
from
672e15a to
73b7b14
Compare
ddeidda
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pclusterin a region with free tier, default instance type is set to the free tier instance type. When runningpclusterin the China (BJS) region or AWS GovCloud (US) regions, default instance type is t3.micro.Free tier is not available in the China (BJS) region and AWS GovCloud (US) regions.
For more information about free tier, please see https://aws.amazon.com/free/free-tier-faqs/
Signed-off-by: Hanwen hanwenli@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.