Skip to content

Conversation

@hanwen-pcluste
Copy link
Contributor

@hanwen-pcluste hanwen-pcluste commented Dec 14, 2020

Signed-off-by: Hanwen hanwenli@amazon.com

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The change is verified by the following tests:

test-suites:
  multiple_nics:
    test_multiple_nics.py::test_multiple_nics:
      dimensions:
        - regions: {{ regions }}
          instances: {{ instances }}
          oss: {{ common.OSS_COMMERCIAL_X86 }}
          schedulers: ["slurm"]

Signed-off-by: Hanwen <hanwenli@amazon.com>
@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #2308 (7cdbeb6) into develop (f60491d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2308      +/-   ##
===========================================
- Coverage    61.67%   61.63%   -0.05%     
===========================================
  Files           40       40              
  Lines         6156     6156              
===========================================
- Hits          3797     3794       -3     
- Misses        2359     2362       +3     
Impacted Files Coverage Δ
cli/src/pcluster/config/validators.py 88.41% <100.00%> (-0.13%) ⬇️
cli/src/pcluster/configure/easyconfig.py 86.60% <0.00%> (-0.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f60491d...7cdbeb6. Read the comment docs.

@hanwen-pcluste hanwen-pcluste merged commit da8ef65 into aws:develop Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants