Fix disable_hyperthreading tests #2534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeidda
added
the
skip-changelog-update
Codecov Report
@@ Coverage Diff @@
## develop #2534 +/- ##
========================================
Coverage 62.39% 62.39%
========================================
Files 40 40
Lines 6255 6255
========================================
Hits 3903 3903
Misses 2352 2352 Continue to review full report at Codecov.
|
tests/integration-tests/conftest.py
Outdated
| def default_threads_per_core(request, instance, region): | ||
| """Return the default threads per core for the given instance type.""" | ||
| # NOTE: currently, .metal instances do not contain the DefaultThreadsPerCore | ||
| # attribute in their VCpuInfo section. This is a known issue with the |
Contributor
There was a problem hiding this comment.
minor: known limitation
ddeidda
force-pushed
the
wip/fix_disable_ht_tests
branch
from
b771801 to
0bf7c53
Compare
demartinofra
previously approved these changes
Mar 16, 2021
ddeidda
force-pushed
the
wip/fix_disable_ht_tests
branch
2 times, most recently
from
5497819 to
f79b808
Compare
demartinofra
previously approved these changes
Mar 16, 2021
Some instance types may have fixed hyperthreading settings; instead this test was assuming that disabling hyperthreading is always possible. Fixed by comparing against instance data instead of fixed number of cores. Signed-off-by: ddeidda <ddeidda@amazon.com>
ddeidda
force-pushed
the
wip/fix_disable_ht_tests
branch
from
f79b808 to
4813e49
Compare
demartinofra
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some instance types may have fixed hyperthreading settings; instead this test was assuming that disabling hyperthreading is always possible. Fixed by comparing against instance data instead of fixed number of cores.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.