Fix pcluster update behavior with additional instance types data #2545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional instance types data must be loaded not only when loading the configuration from file, but also from CloudFormation in order to allow the refresh operations to work correctly. This commit also marks as ignored the update policy of the `instance_types_data` parameter to avoid changes being displayed just because of the json data re-ordering. Signed-off-by: ddeidda <ddeidda@amazon.com>
Codecov Report
@@ Coverage Diff @@
## release-2.10 #2545 +/- ##
=============================================
Coverage 62.35% 62.35%
=============================================
Files 40 40
Lines 6264 6264
=============================================
Hits 3906 3906
Misses 2358 2358
Continue to review full report at Codecov.
|
tilne
added
the
skip-changelog-update
tilne
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional instance types data must be loaded not only when loading the configuration from file, but also from CloudFormation in order to allow the refresh operations to work correctly.
This commit also marks as ignored the update policy of the
instance_types_dataparameter to avoid changes being displayed just because of the json data re-ordering.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.