Fix cluster configuration schema #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3010 +/- ##
========================================
Coverage 79.81% 79.81%
========================================
Files 148 148
Lines 11565 11565
========================================
Hits 9231 9231
Misses 2334 2334
Continue to review full report at Codecov.
|
hanwen-pcluste
force-pushed
the
pcluster3Jul22
branch
2 times, most recently
from
03098e2 to
64797eb
Compare
1. Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes 2. Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section 3. Allow update Role section under IAM section. Same reasoning as #2 4. Require key value in tag section 5. Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments Signed-off-by: Hanwen <hanwenli@amazon.com>
hanwen-pcluste
force-pushed
the
pcluster3Jul22
branch
from
64797eb to
8bcd7e8
Compare
hanwen-pcluste
added
the
skip-changelog-update
enrico-usai
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow configure DisableSimultaneousMultithreading only for Slurm compute nodes. pcluster is currently not able to configure AWS Batch compute nodes
Allow update RootVolume. This means user can add the section to the configuration file after the cluster is created. Then user can adjust updatable parameters in the section
Allow update Role section under IAM section. Same reasoning as above
Require key value in tag section
Modify awsbatch.full.yaml, awsbatch.simple.yaml, slurm.full.yaml to remove unnecessary comments
Signed-off-by: Hanwen hanwenli@amazon.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.