Skip to content

Conversation

@mauri-melato
Copy link
Contributor

Description of changes

  • Reviewed the changelog item list and wording.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mauri-melato mauri-melato requested a review from a team as a code owner July 18, 2022 19:29
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #4203 (1a4ab9c) into develop (3d6a235) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4203   +/-   ##
========================================
  Coverage    86.86%   86.86%           
========================================
  Files          159      159           
  Lines        13495    13495           
========================================
  Hits         11722    11722           
  Misses        1773     1773           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d6a235...1a4ab9c. Read the comment docs.

@enrico-usai
Copy link
Contributor

We have to add Multi-nic changes: https://github.com/aws/aws-parallelcluster-cookbook/pull/1485/files

Copy link
Contributor

@enrico-usai enrico-usai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add:

- Fix file handle leak in `computemgtd`.

from: https://github.com/aws/aws-parallelcluster/pull/4154/files
In this way we'll close it as duplicate.

Added missing important software updates and features.
@mauri-melato
Copy link
Contributor Author

We have to add Multi-nic changes: https://github.com/aws/aws-parallelcluster-cookbook/pull/1485/files

Copy link
Contributor

@demartinofra demartinofra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@mauri-melato mauri-melato merged commit fdc0dfd into develop Jul 21, 2022
@demartinofra demartinofra deleted the mauri-melato-patch-1 branch July 21, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants