Skip to content

Conversation

@demartinofra
Copy link
Contributor

Description of changes

PR #4652 was breaking the usage of --use-default-iam-credentials because the custom_cli_credentials param was being passed as a kwarg to the pcluster command.

As part of the fix I made the custom_cli_credentials an explicit argument assuming that generics kwargs are being used to propagate custom args to the pcluster commands. In this case this is a known argument we want to handle as part of the framework, therefore making it explicit with a default.

Tests

  • Locally executed tests with and without the --use-default-iam-credentials flag

References

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Francesco De Martino <fdm@amazon.com>
@demartinofra demartinofra added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #4732 (91fdf3e) into develop (876211e) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4732      +/-   ##
===========================================
+ Coverage    89.10%   89.17%   +0.07%     
===========================================
  Files          163      163              
  Lines        14369    14369              
===========================================
+ Hits         12803    12814      +11     
+ Misses        1566     1555      -11     
Impacted Files Coverage Δ
cli/src/pcluster/templates/cdk_builder_utils.py 96.69% <ø> (+4.13%) ⬆️
cli/src/pcluster/config/cluster_config.py 95.71% <0.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@demartinofra demartinofra marked this pull request as ready for review December 19, 2022 17:57
@demartinofra demartinofra requested review from a team as code owners December 19, 2022 17:57
Copy link
Contributor

@himani2411 himani2411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my reference, approving as this changes dont affect our Dev Jenkins and will only be used for local testing.

@himani2411 himani2411 merged commit a4729d5 into aws:develop Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants