Skip to content

Conversation

@enrico-usai
Copy link
Contributor

@enrico-usai enrico-usai commented Jun 22, 2023

Description of changes

Added new os in:

  • Image Builder components
  • constants used by pcluster commands
  • CloudWatch dashboard builder
  • list of OS supported by DCV
  • pcluster configure and other unit tests
  • system-analyzer.sh
  • pc_support json file
  • changelog

Tests

  • Fix new_os.yaml template to always use the NEW_OS placeholder
    • This configuration file must be used to test a new OS, so it's useless to execute tests for other OSes.
  • TODO: add new os in the develop.yml configuration.

### References

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8fc0fcd) 89.89% compared to head (d35aa5e) 89.63%.

❗ Current head d35aa5e differs from pull request most recent head d224beb. Consider uploading reports for the commit d224beb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5423      +/-   ##
===========================================
- Coverage    89.89%   89.63%   -0.27%     
===========================================
  Files          179      174       -5     
  Lines        15432    14842     -590     
===========================================
- Hits         13873    13303     -570     
+ Misses        1559     1539      -20     
Flag Coverage Δ
unittests 89.63% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 38 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@enrico-usai enrico-usai force-pushed the wip/rocky branch 2 times, most recently from eeb9807 to 1e9d40a Compare June 23, 2023 09:30
@enrico-usai enrico-usai changed the title Rocky linux support for image builder [POC] Add support for Rocky Linux 8 Jun 23, 2023
@enrico-usai enrico-usai force-pushed the wip/rocky branch 5 times, most recently from a456eb5 to dd52ff0 Compare June 28, 2023 08:09
@enrico-usai enrico-usai force-pushed the wip/rocky branch 2 times, most recently from 560bc5b to ef8b822 Compare August 18, 2023 10:55
@niallguerin
Copy link

Hi Enrico,
I see a new aws pc 3.7.x was released this week. Is there any issue that is holding off the release of support for rocky-8 based on what's been tested in above branch to date as I don't see it covered in new release yet in the new release.

@enrico-usai
Copy link
Contributor Author

Hi @niallguerin,

the support of Rocky Linux 8 wasn't scheduled for 3.7.0 release, where we added Ubuntu22 support.

We have to complete internal testing and will evaluate to support it in the future releases of ParallelCluster.
Thanks for asking.

@panda1100
Copy link

I'm looking forward to the release of this PR. This will be a good test bed for MPI applications that built for EL8 systems.

@enrico-usai enrico-usai changed the title [POC] Add support for Rocky Linux 8 [develop] Add support for Rocky Linux 8 Sep 26, 2023
@enrico-usai enrico-usai marked this pull request as ready for review September 26, 2023 13:58
@enrico-usai enrico-usai requested review from a team as code owners September 26, 2023 13:58
Added new os in:
* Image Builder components
* constants used by pcluster commands
* CloudWatch dashboard builder
* list of OS supported by DCV
* pcluster configure and other unit tests
* system-analyzer.sh
* pc_support json file
* changelog

### References

Using `Rocky-8-EC2-Base-8.*` as base AMI from official Rocky Linux account:
https://rockylinux.org/cloud-images/

Signed-off-by: Enrico Usai <usai@amazon.com>
@panda1100
Copy link

Thank you Enrico-san! @enrico-usai

@enrico-usai enrico-usai merged commit c373103 into aws:develop Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants