Skip to content

Conversation

@himani2411
Copy link
Contributor

Description of changes

  • Deprecating support for Ubuntu18

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners June 27, 2023 18:56
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Jun 27, 2023
@himani2411 himani2411 force-pushed the wip/deprecate-ubuntu18 branch 2 times, most recently from bd1d224 to 8d70021 Compare June 27, 2023 19:59
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #5436 (006467f) into develop (c157a81) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 006467f differs from pull request most recent head b06b52c. Consider uploading reports for the commit b06b52c to get more accurate results

@@             Coverage Diff             @@
##           develop    #5436      +/-   ##
===========================================
+ Coverage    89.67%   89.68%   +0.01%     
===========================================
  Files          175      175              
  Lines        15014    15014              
===========================================
+ Hits         13464    13466       +2     
+ Misses        1550     1548       -2     
Flag Coverage Δ
unittests 89.68% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@himani2411 himani2411 force-pushed the wip/deprecate-ubuntu18 branch from 8d70021 to bd42c45 Compare June 27, 2023 20:26
@himani2411 himani2411 force-pushed the wip/deprecate-ubuntu18 branch 2 times, most recently from 1af993c to 006467f Compare June 28, 2023 13:45
@himani2411 himani2411 force-pushed the wip/deprecate-ubuntu18 branch from 006467f to b06b52c Compare June 28, 2023 14:01
- regions: [ "ap-northeast-2" ]
instances: {{ common.INSTANCES_DEFAULT_X86 }}
oss: [ "ubuntu1804" ]
oss: [ "ubuntu2004" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future we should remove this byos (Bring your own scheduler) patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@himani2411 himani2411 merged commit 7066d8d into aws:develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants