Skip to content

Conversation

@NSsirena
Copy link
Contributor

@NSsirena NSsirena commented Aug 1, 2023

Description of changes

  • Reset cached values when cluster is stopped

Tests

  • test slurm protected_mode is failing due to cached results.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Nicola Sirena <nssirena@amazon.com>
@NSsirena NSsirena added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Aug 1, 2023
@NSsirena NSsirena requested review from a team as code owners August 1, 2023 13:17
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #5550 (876cca7) into develop (a9bf358) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5550   +/-   ##
========================================
  Coverage    89.88%   89.88%           
========================================
  Files          179      179           
  Lines        15347    15347           
========================================
  Hits         13794    13794           
  Misses        1553     1553           
Flag Coverage Δ
unittests 89.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@EddyMM EddyMM merged commit 1884212 into aws:develop Aug 1, 2023
kkolur5 pushed a commit to kkolur5/aws-parallelcluster that referenced this pull request Aug 11, 2023
Signed-off-by: Nicola Sirena <nssirena@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants