Skip to content

[Develop] Move proxy setting to the beginning of user_data.sh to avoid cfn command failure issue #6633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 6, 2025
Merged

[Develop] Move proxy setting to the beginning of user_data.sh to avoid cfn command failure issue #6633

merged 3 commits into from
Jan 6, 2025

Conversation

@hehe7318
Copy link
Contributor

@hehe7318 hehe7318 commented Jan 3, 2025 •
edited
Loading

Description of changes

  • Move proxy setting to the beginning of ComputeNode and LoginNode user_data.sh
  • This can fix the issue where when using Proxy, ComputeNode/LoginNode bootstrap would fail.

Tests

  • Unit tests done. Passed.
  • Manually tests done, passed. Now using proxy will not cause the compute node bootstrap failure.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hehe7318 hehe7318 added the 3.x label Jan 3, 2025
@hehe7318 hehe7318 requested review from a team as code owners January 3, 2025 18:51
himani2411
himani2411 requested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@himani2411 himani2411 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do the same for other node's user_data.sh

@hehe7318 hehe7318 changed the title [Develop] Move proxy setting to the beginning of compute node user_data.sh to avoid cfn command failure issue [Develop] Move proxy setting to the beginning of user_data.sh to avoid cfn command failure issue Jan 3, 2025
@hehe7318 hehe7318 enabled auto-merge (squash) January 6, 2025 15:32
@hehe7318 hehe7318 merged commit cd46acd into aws:develop Jan 6, 2025
24 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster that referenced this pull request Feb 26, 2025
@hehe7318 @hgreebe
[Develop] Move proxy setting to the beginning of user_data.sh to avoi…
e6ed1d5 
…d cfn command failure issue (aws#6633)

* Move proxy setting to the beginning of ComputeNode and LoginNode user_data.sh
* This can fix the issue where when using Proxy, ComputeNode/LoginNode bootstrap would fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@himani2411 himani2411 himani2411 approved these changes

Assignees

No one assigned

Labels

3.x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hehe7318 @himani2411