Skip to content

Conversation

@dreambeyondorange
Copy link
Contributor

@dreambeyondorange dreambeyondorange commented Jan 10, 2025

Tests

  • Integ test test_efs_access_point passed

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dreambeyondorange dreambeyondorange added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jan 10, 2025
@dreambeyondorange dreambeyondorange requested review from a team as code owners January 10, 2025 19:41
@hanwen-cluster hanwen-cluster changed the title Add update to the test_efs_access_point test [integ-tests] Add update to the test_efs_access_point test Jan 10, 2025
raise

logging.info("Found following unused test functions: %s", json.dumps(unused_test_functions, indent=2))
logging.debug("Found following unused test functions: %s", json.dumps(unused_test_functions, indent=2))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we keep it as INFO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this debug since it ends up printing a lot of extra info we usually don't need. As long as we have the set of collected tests that we are running, we know which ones are not.

@dreambeyondorange dreambeyondorange merged commit 8f86b20 into aws:develop Jan 10, 2025
27 checks passed
hgreebe pushed a commit to hgreebe/aws-parallelcluster that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants