Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ CHANGELOG
- Set instance ID and instance type information in Slurm upon compute nodes launch.
- Install NVIDIA drivers without the option 'no-cc-version-check', which is now deprecated in the NVIDIA installer.
- Add validator to enforce up to 10- login node pools.
- Update the default root volume size to 45 GB.

**BUG FIXES**
- Remove usage of cfn-init for compute node bootstrapping to reduce node scale up time.
Expand Down
2 changes: 1 addition & 1 deletion cli/src/pcluster/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@
"io2": 100,
"gp3": 3000,
}
EBS_VOLUME_SIZE_DEFAULT = 40
EBS_VOLUME_SIZE_DEFAULT = 45
EBS_VOLUME_TYPE_DEFAULT = "gp3"

DEFAULT_MAX_COUNT = 10
Expand Down
2 changes: 1 addition & 1 deletion cli/src/pcluster/imagebuilder_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
from pcluster.utils import get_url_scheme, yaml_load

ROOT_VOLUME_TYPE = "gp3"
PCLUSTER_RESERVED_VOLUME_SIZE = 32
PCLUSTER_RESERVED_VOLUME_SIZE = 37
AMI_NAME_REQUIRED_SUBSTRING = " {{ imagebuilder:buildDate }}"


Expand Down
2 changes: 1 addition & 1 deletion cli/tests/pcluster/example_configs/awsbatch.full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ HeadNode:
AllowedIps: 1.2.3.4/32
LocalStorage:
RootVolume:
Size: 37
Size: 45
Encrypted: true
DeleteOnTermination: true
EphemeralVolume:
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/pcluster/example_configs/slurm.full.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ HeadNode:
AllowedIps: 1.2.3.4/32
LocalStorage:
RootVolume:
Size: 40
Size: 45
Encrypted: true
VolumeType: gp2
Iops: 100
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ HeadNode:
AllowedIps: 1.2.3.4/32
LocalStorage:
RootVolume:
Size: 40
Size: 45
Encrypted: true
VolumeType: gp2
Iops: 100
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ HeadNode:
DeleteOnTermination: true
Encrypted: true
Iops: 100
Size: 40
Size: 45
Throughput: null
VolumeType: gp2
Networking:
Expand Down
8 changes: 4 additions & 4 deletions cli/tests/pcluster/templates/test_imagebuilder_stack.py
Original file line number Diff line number Diff line change
Expand Up @@ -3317,7 +3317,7 @@ def test_imagebuilder_distribution_configuraton(mocker, resource, response, expe
}
],
},
{"Encrypted": False, "VolumeSize": 40, "VolumeType": "gp3"},
{"Encrypted": False, "VolumeSize": 45, "VolumeType": "gp3"},
),
(
{
Expand Down Expand Up @@ -3350,7 +3350,7 @@ def test_imagebuilder_distribution_configuraton(mocker, resource, response, expe
{
"imagebuilder": {
"image": {
"root_volume": {"size": 40, "encrypted": True},
"root_volume": {"size": 45, "encrypted": True},
},
"build": {
"parent_image": "arn:aws:imagebuilder:us-east-1:aws:image/amazon-linux-2-x86/x.x.x",
Expand All @@ -3369,7 +3369,7 @@ def test_imagebuilder_distribution_configuraton(mocker, resource, response, expe
}
],
},
{"Encrypted": True, "VolumeSize": 40, "VolumeType": "gp3"},
{"Encrypted": True, "VolumeSize": 45, "VolumeType": "gp3"},
),
(
{
Expand Down Expand Up @@ -3399,7 +3399,7 @@ def test_imagebuilder_distribution_configuraton(mocker, resource, response, expe
},
{
"Encrypted": True,
"VolumeSize": 82,
"VolumeSize": 87,
"VolumeType": "gp3",
"KmsKeyId": "arn:aws:kms:us-east-1:111122223333:key/1234abcd-12ab-34cd-56ef-1234567890ab",
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ HeadNode:
AllowedIps: 1.2.3.4/32
LocalStorage:
RootVolume:
Size: 40
Size: 45
Encrypted: true
EphemeralVolume:
MountDir: /test
Expand Down
2 changes: 1 addition & 1 deletion cli/tests/pcluster/validators/test_cluster_validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -3225,7 +3225,7 @@ class TestDictLaunchTemplateBuilder:
"Ebs": {
"Encrypted": True,
"VolumeType": "mockVolumeType",
"VolumeSize": 40,
"VolumeSize": 45,
"Iops": 15,
"Throughput": 20,
"DeleteOnTermination": True,
Expand Down
6 changes: 3 additions & 3 deletions cli/tests/pcluster3_config_converter/test_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@
scaling_settings = custom
scheduler = slurm
disable_cluster_dns = true
compute_root_volume_size = 40
compute_root_volume_size = 45

[vpc default]
vpc_id = vpc-0e0f223cc35256b9a
Expand Down Expand Up @@ -957,7 +957,7 @@
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
Networking:
AdditionalSecurityGroups:
- sg-xxxxxx
Expand Down Expand Up @@ -1001,7 +1001,7 @@
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
Networking:
AdditionalSecurityGroups:
- sg-xxxxxx
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Image:
- Key: dummyImageTag
Value: dummyImageTag
RootVolume:
Size: 40
Size: 45

Build:
Iam:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@ SharedStorage:
EbsSettings:
Raid:
Type: 1
Size: 40
Size: 45
{% endif %}
4 changes: 2 additions & 2 deletions tests/integration-tests/tests/update/test_update.py
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,8 @@ def test_queue_parameters_update(
):
"""Test update cluster with drain strategy."""
# Create cluster with initial configuration
initial_compute_root_volume_size = 40
updated_compute_root_volume_size = 45
initial_compute_root_volume_size = 45
updated_compute_root_volume_size = 50
# If you are running this test in your personal account, then you must have
# ParallelCluster AMIs following the official naming convention
# and set allow_private_ami to True.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Scheduling:
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
CustomActions:
OnNodeStart:
Script: s3://{{ resource_bucket }}/scripts/updated_preinstall.sh # Updated parameter value
Expand Down Expand Up @@ -81,7 +81,7 @@ Scheduling:
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
CustomActions: # New section
OnNodeStart:
Script: s3://{{ resource_bucket }}/scripts/updated_preinstall.sh
Expand Down Expand Up @@ -114,7 +114,7 @@ Scheduling:
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
CustomActions:
OnNodeStart:
Script: s3://{{ resource_bucket }}/scripts/updated_preinstall.sh
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Scheduling:
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
CustomActions:
OnNodeStart:
Script: s3://{{ resource_bucket }}/scripts/preinstall.sh
Expand Down Expand Up @@ -65,7 +65,7 @@ Scheduling:
ComputeSettings:
LocalStorage:
RootVolume:
Size: 40
Size: 45
ComputeResources:
- Name: queue2-i1
Efa:
Expand Down
Loading