Remove berkshelf #6909
Merged
Remove berkshelf #6909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanwen-cluster
force-pushed
the
developjul9
branch
from
9650697 to
49b3991
Compare
hanwen-cluster
commented
Jul 9, 2025
Comment on lines
313
to
314
| curl --retry 3 -L -o gems.tgz https://${AWS::Region}-aws-parallelcluster.s3.${AWS::Region}.${AWS::URLSuffix}/archives/dependencies/ruby/gems.tgz | ||
| tar -xf gems.tgz |
hgreebe
previously approved these changes
Jul 9, 2025
Berkshelf is a dependency manager for Chef cookbooks. With it, you can depend on community cookbooks and include them in your workflow. Berkshelf is not useful when all cookbooks are local. ParallelCluster cookbook has all third party cookbooks ready locally. Reducing software we depend on improves stability of the product. (e.g we have one known issue related to berkshelf https://github.com/aws/aws-parallelcluster/wiki/(3.8.0-%E2%80%90-3.9.3)-ParallelCluster-Build-Image-Failing-during-Installation-of-Minitar-Ruby-Gem-Dependency)
hanwen-cluster
force-pushed
the
developjul9
branch
from
49b3991 to
91632b1
Compare
hgreebe
approved these changes
Jul 9, 2025
hanwen-cluster
added a commit
to hanwen-cluster/aws-parallelcluster
that referenced
this pull request
Jul 24, 2025
This is a bug from aws#6909. In the PR, I tested custom cookbook setting didn't produce errors, but didn't test it was actually used. The custom cookbook was extracted wrongly to /tmp/cookbooks instead of /etc/chef. The new command is copied from the command in build-image process https://github.com/aws/aws-parallelcluster/blob/develop/cli/src/pcluster/resources/imagebuilder/parallelcluster.yaml#L200
hanwen-cluster
added a commit
that referenced
this pull request
Jul 24, 2025
This is a bug from #6909. In the PR, I tested custom cookbook setting didn't produce errors, but didn't test it was actually used. The custom cookbook was extracted wrongly to /tmp/cookbooks instead of /etc/chef. The new command is copied from the command in build-image process https://github.com/aws/aws-parallelcluster/blob/develop/cli/src/pcluster/resources/imagebuilder/parallelcluster.yaml#L200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Berkshelf is a dependency manager for Chef cookbooks. With it, you can depend on community cookbooks and include them in your workflow. Berkshelf is not useful when all cookbooks are local. ParallelCluster cookbook has all third party cookbooks ready locally.
Reducing software we depend on improves stability of the product. (e.g we have one known issue related to berkshelf https://github.com/aws/aws-parallelcluster/wiki/(3.8.0-%E2%80%90-3.9.3)-ParallelCluster-Build-Image-Failing-during-Installation-of-Minitar-Ruby-Gem-Dependency)
Tests
This must be merged with aws/aws-parallelcluster-cookbook#2989
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.