Skip to content

Conversation

@hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Jul 18, 2025

Description of changes

  • Add check that slurm state remains the same after deleting the cluster id state file

Tests

  • Ran test_slurm_accounting

References

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe hgreebe marked this pull request as ready for review July 18, 2025 17:43
@hgreebe hgreebe requested review from a team as code owners July 18, 2025 17:43

job_1_id = scheduler_commands.submit_command_and_assert_job_accepted(
submit_command_args={
"command": "srun sleep 600",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and for the other job, could you please increase the sleep time to a dummy large number, say 3000 (as we do in other tests), so that there is clearly no risk of job changing state if the forced update takes too long?

@hgreebe hgreebe enabled auto-merge (rebase) July 22, 2025 11:11
@hgreebe hgreebe added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Jul 22, 2025
@hgreebe hgreebe merged commit a50a3af into aws:develop Jul 22, 2025
44 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants