Remove build-time detection of supported WinINet/WinHTTP protocol versions. #3201
Conversation
| #endif | ||
|
|
||
| DWORD ConvertHttpVersionToWinHttpVersion(const Aws::Http::Version version) | ||
| std::initializer_list<DWORD> GetWinHttpVersionsToTry(const Aws::Http::Version version) |
There was a problem hiding this comment.
I don't think that initializer_list works in such context (return by value from a method), it is probably an undefined behavior here.
I'd suggest returning a const reference to a local static const object, such as
const std::initializer_list<DWORD>& GetWinHttpVersionsToTry(const Aws::Http::Version version) {
...
else if (version == Version::HTTP_VERSION_3)
{
static const std::initializer_list<DWORD> HTTP123{ WINHTTP_PROTOCOL_FLAG_HTTP3 | WINHTTP_PROTOCOL_FLAG_HTTP2, WINHTTP_PROTOCOL_FLAG_HTTP2};
return HTTP123;
}
or use some other approach.
Please check the cpp reference:
Copying a std::initializer_list does not copy the backing array of the corresponding initializer list.
https://en.cppreference.com/w/cpp/utility/initializer_list
see also: https://stackoverflow.com/questions/15286450/lifetime-of-a-stdinitializer-list-return-value
|
Hi @teo-tsirpanis , thank you a lot for submitting this pull request. While the intention is clear and very good, I have a concern about std::initializer_list usage. |
2 participants
Issue #, if available:
Description of changes:
This PR removes build-time detection of WinHTTP and WinINet support for HTTP/2 and HTTP/3. In its place, we always attempt setting the HTTP version, ignoring errors (on WinHTTP in certin cases we try both enabling both HTTP/2 and 3, and then only 2).
The main reason for this is to make cross-compilation from x64 to ARM64 easier. Besides that, the built binaries will automatically take advantage of the capabilities of the system's HTTP stack even if they are built on an older machine.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.