Codegen: don't include exception classes that are not generated #3390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbera87
approved these changes
Apr 23, 2025
SergeyRyabinin
added a commit
that referenced
this pull request
Apr 23, 2025
SergeyRyabinin
force-pushed
the
sr/modeledErrorInclude
branch
from
8d9c34c to
d81ed40
Compare
SergeyRyabinin
force-pushed
the
sr/modeledErrorInclude
branch
from
d81ed40 to
dcc2b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3389
Description of changes:
SDK Codegen historically skips generation for shapes that are the "modeled exceptions" (if the exception on the model has only "Message" member), with a reasoning that those exceptions can be represented by a CoreError exception class.
So they must not be included.
Note: exception means AWS c2j/smithy exception shape not C++ exception here.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.