Skip to content

Conversation

@alextwoods
Copy link
Contributor

Set the RESOLVED_ACCOUNT_ID (T) metric only when accountID is actually resolved.

Motivation and Context

The current generated code will always set the T metric on user-agent regardless of whether an accountID is actually available or not.

Modifications

Add a check that accountID is set after resolving it before setting the business metric.

Testing

Added new unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@alextwoods alextwoods requested a review from a team as a code owner October 14, 2025 19:14
@sonarqubecloud
Copy link

Copy link
Contributor

@RanVaknin RanVaknin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alextwoods alextwoods added this pull request to the merge queue Oct 14, 2025
Merged via the queue into master with commit 6f7f0e7 Oct 14, 2025
38 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2025
@alextwoods alextwoods deleted the alexwoo/fix-accountid-metric branch October 14, 2025 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants