Remove obsolete useSra customization config #6476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
Oct 15, 2025
| */ | ||
| @Generated("software.amazon.awssdk:codegen") | ||
| @SdkInternalApi | ||
| abstract class DefaultH2BaseClientBuilder<B extends H2BaseClientBuilder<B, C>, C> extends AwsDefaultClientBuilder<B, C> { |
There was a problem hiding this comment.
This test fixture was previously on non-SRA code path, hence the change
|
|
||
| import java.util.ArrayList; | ||
| import java.util.Collections; | ||
| import java.util.HashMap; |
There was a problem hiding this comment.
This test fixture was previously on non-SRA code path, hence the change
| try { | ||
| apiCallMetricCollector.reportMetric(CoreMetric.SERVICE_ID, "Database Service"); | ||
| apiCallMetricCollector.reportMetric(CoreMetric.OPERATION_NAME, "opWithSigv4UnSignedPayloadAndStreaming"); | ||
| if (!isSignerOverridden(clientConfiguration)) { |
There was a problem hiding this comment.
This test fixture was previously on non-SRA code path, hence the change
zoewangg
force-pushed
the
zoewang/master/removeUseSraConfig
branch
from
33dc89c to
8b6276c
Compare
|
millems
approved these changes
Oct 16, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
• Removed the obsolete useSraAuth configuration flag that defaulted to true over a year ago
• Eliminated all conditional logic checking this flags
• Removed legacy test fixtures that were no longer used
• Simplified code generation by keeping only the SRA code paths