Skip to content

Conversation

@S-Saranya1
Copy link
Contributor

@S-Saranya1 S-Saranya1 commented Oct 16, 2025

Add business metrics tracking support for PROTOCOL_RPC_V2_CBOR feature ID to track when an operation called using the Smithy RPC v2 CBOR protocol.

Motivation and Context

Enable business metrics tracking for RPC v2 CBOR protocol usage to understand protocol adoption.

Modifications

Added PROTOCOL_RPC_V2_CBOR("M") business metric feature ID to BusinessMetricFeatureId enum
Modified AwsExecutionContextBuilder to add RPC v2 CBOR business metrics when the protocol is Smithy RPC V2

Testing

Added ProtocolRpcV2CborUserAgentTest to verify User-Agent header contains "M" metric for RPC v2 CBOR clients.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@S-Saranya1 S-Saranya1 requested a review from a team as a code owner October 16, 2025 18:30
@S-Saranya1 S-Saranya1 changed the title Implementing ProtocolRpcV2Cbor FeatureID Implementing Protocol Rpc V2 Cbor FeatureID Oct 16, 2025
@S-Saranya1 S-Saranya1 added the no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required label Oct 17, 2025
@sonarqubecloud
Copy link

@S-Saranya1 S-Saranya1 added this pull request to the merge queue Oct 20, 2025
Merged via the queue into master with commit 3343d58 Oct 20, 2025
42 of 43 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2025
@S-Saranya1 S-Saranya1 deleted the somepal/cbor-feature-ID branch October 20, 2025 18:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-api-surface-area-change Indicate there is no API surface area change and thus API surface area review is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants