Rename RequestBatchBuffer methods from 'flushable' to 'extract' to clarify it doesn't do the flushing #6485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arify it doesn't do the flushing
joviegas
added
the
changelog-not-required
1 task
zoewangg
reviewed
Oct 17, 2025
| flushBuffer(batchKey, flushableRequests); | ||
| while (!extractedEntries.isEmpty()) { | ||
| flushBuffer(batchKey, extractedEntries); | ||
| extractedEntries = requestsAndResponsesMaps.extractBatchIfReady(batchKey); |
There was a problem hiding this comment.
Looks like this line is new, is this expected?
There was a problem hiding this comment.
It was not intended , copy paste error from line 167
zoewangg
approved these changes
Oct 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
RequestBatchBufferclass had confusing method names that suggested it was responsible for flushing entries, when it actually just extracts them from the buffer. The actual flushing is done byRequestBatchManager. This was done to handle comment from #5418 (comment)Modifications
Renamed three public methods in
RequestBatchBufferto better reflect what they actually do:flushableRequests()→extractBatchIfReady()- extracts entries when batch is full or size limit reachedflushableRequestsOnByteLimitBeforeAdd()→extractBatchIfSizeExceeded()- extracts entries before adding a new request if size would be exceededflushableScheduledRequests()→extractEntriesForScheduledFlush()- extracts entries during scheduled flushAlso renamed the private helper method
extractFlushedEntries()toextractEntries()for consistency.Updated all callers in
BatchingMap,RequestBatchManager, and test files to use the new method names.Testing
Ran the full SQS module test suite with
mvn clean install -pl :sqs -P quick --am -rf :sqs.License