Skip to content

Consolidate duplicate code in legacy auth and new auth paths #6494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 27, 2025
Merged

Consolidate duplicate code in legacy auth and new auth paths #6494

merged 8 commits into from
Oct 27, 2025

Conversation

@zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Oct 21, 2025 •
edited
Loading

All changes have been reviewed previously in #6480, #6484, #6491, #6497 and #6504

As part of the consolidation, we moved some private APIs to utils module and they are now protected APIs:

  • SignerConstant
  • SdkLengthAwareInputStream -> LengthAwareInputStream
  • FifoCache

@zoewangg
Duplicate code reduction part 1: consolidate duplicate signing relate…
8c81f83 
…d classes (#6480)

* Consolidate duplicate signing related classes

* Fix build
@zoewangg
Duplicate code reduction part 2: clean up checksum classes (#6484)
21479fe 
* Duplicate code reduction part 2: clean up checksum classes

* Fix build
@zoewangg
Reusing common logic (#6491)
325bfcf
@zoewangg zoewangg requested a review from a team as a code owner October 21, 2025 19:49
@zoewangg zoewangg added the api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team label Oct 23, 2025
@zoewangg zoewangg added the changelog-not-required Indicate changelog entry is not required for a specific PR label Oct 24, 2025
@zoewangg
Copy link
Contributor Author

Marked changelog-not-required because this is not a customer-facing feature

@zoewangg zoewangg added this pull request to the merge queue Oct 27, 2025
dagnir added a commit that referenced this pull request Oct 27, 2025
@dagnir
Bump minor version to 2.37.0
400c13f 
Prepping to release

 - #6494
 - #6514
@dagnir dagnir mentioned this pull request Oct 27, 2025
Merged
12 tasks
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2025
@zoewangg zoewangg enabled auto-merge October 27, 2025 21:41
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue Oct 27, 2025
Merged via the queue into master with commit 87facc3 Oct 27, 2025
39 checks passed
@github-actions
Copy link

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alextwoods alextwoods alextwoods approved these changes

Assignees

No one assigned

Labels

api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team changelog-not-required Indicate changelog entry is not required for a specific PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zoewangg @alextwoods