Circular dependency in packages

[ciscoheat]

Checkboxes for prior research

• I've gone through Developer Guide and API reference
• I've checked AWS Forums and StackOverflow.
• I've searched for previous similar issues and didn't find any solution.

Describe the bug

I'm getting circular dependency warnings when building an app with this library.

SDK version number

@aws-sdk/client-s3@3.267.0

Which JavaScript Runtime is this issue in?

Node.js

Details of the browser/Node.js/ReactNative version

v18.10.0

Reproduction Steps

Link to repo: https://github.com/ciscoheat/aws-circular

The code in question is in src/routes/+page.server.ts:

import { S3Client } from "@aws-sdk/client-s3";

export const load = async () => {
  new S3Client({});
  return {};
};

The warnings occur when executing npm run build in the repo.

Observed Behavior

vite v4.1.1 building SSR bundle for production...
✓ 57 modules transformed.
10:04:37 [vite-plugin-svelte] ssr compile done.
package         files     time     avg
aws-circular        4   46.7ms  11.7ms

vite v4.1.1 building for production...
✓ 39 modules transformed.
10:04:38 [vite-plugin-svelte] dom compile done.
package         files     time     avg
aws-circular        4   66.6ms  16.6ms
.svelte-kit/output/client/_app/version.json                                          0.03 kB
.svelte-kit/output/client/vite-manifest.json                                         2.93 kB
.svelte-kit/output/client/_app/immutable/chunks/1-b75ed4b9.js                        0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/0-c0f28063.js                        0.09 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/chunks/2-ca7d93d5.js                        0.10 kB │ gzip:  0.10 kB
.svelte-kit/output/client/_app/immutable/components/layout.svelte-32179dfc.js        0.54 kB │ gzip:  0.36 kB
.svelte-kit/output/client/_app/immutable/components/pages/_page.svelte-d23e61b0.js   0.83 kB │ gzip:  0.48 kB
.svelte-kit/output/client/_app/immutable/components/error.svelte-628c3fab.js         0.98 kB │ gzip:  0.57 kB
.svelte-kit/output/client/_app/immutable/chunks/singletons-efdfcb03.js               2.56 kB │ gzip:  1.34 kB
.svelte-kit/output/client/_app/immutable/chunks/index-65bc829e.js                    6.93 kB │ gzip:  2.81 kB
.svelte-kit/output/client/_app/immutable/start-e3b84297.js                          28.26 kB │ gzip: 10.97 kB
.svelte-kit/output/server/vite-manifest.json                    1.84 kB
.svelte-kit/output/server/entries/pages/_page.server.ts.js      0.13 kB
.svelte-kit/output/server/internal.js                           0.19 kB
.svelte-kit/output/server/entries/fallbacks/layout.svelte.js    0.24 kB
.svelte-kit/output/server/entries/pages/_page.svelte.js         0.32 kB
.svelte-kit/output/server/entries/fallbacks/error.svelte.js     0.83 kB
.svelte-kit/output/server/chunks/index.js                       3.29 kB
.svelte-kit/output/server/chunks/internal.js                    4.98 kB
.svelte-kit/output/server/index.js                            100.37 kB

Run npm run preview to preview your production build locally.

> Using @sveltejs/adapter-node
Circular dependency: node_modules/.pnpm/@aws-crypto+crc32@3.0.0/node_modules/@aws-crypto/crc32/build/index.js -> node_modules/.pnpm/@aws-crypto+crc32@3.0.0/node_modules/@aws-crypto/crc32/build/aws_crc32.js -> node_modules/.pnpm/@aws-crypto+crc32@3.0.0/node_modules/@aws-crypto/crc32/build/index.js
Circular dependency: node_modules/.pnpm/@aws-crypto+crc32c@3.0.0/node_modules/@aws-crypto/crc32c/build/index.js -> node_modules/.pnpm/@aws-crypto+crc32c@3.0.0/node_modules/@aws-crypto/crc32c/build/aws_crc32c.js -> node_modules/.pnpm/@aws-crypto+crc32c@3.0.0/node_modules/@aws-crypto/crc32c/build/index.js
Circular dependency: node_modules/.pnpm/@aws-sdk+credential-provider-ini@3.267.0/node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveProfileData.js -> node_modules/.pnpm/@aws-sdk+credential-provider-ini@3.267.0/node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveAssumeRoleCredentials.js -> node_modules/.pnpm/@aws-sdk+credential-provider-ini@3.267.0/node_modules/@aws-sdk/credential-provider-ini/dist-es/resolveProfileData.js
Circular dependency: node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/callFunction.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/evaluateExpression.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/callFunction.js
Circular dependency: node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/getEndpointProperties.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/getEndpointProperty.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/getEndpointProperties.js
Circular dependency: node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/evaluateRules.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/evaluateTreeRule.js -> node_modules/.pnpm/@aws-sdk+util-endpoints@3.267.0/node_modules/@aws-sdk/util-endpoints/dist-es/utils/evaluateRules.js
  ✔ done

Expected Behavior

No circular dependency warnings.

Possible Solution

No response

Additional Information/Context

I've had some unexplainable server errors on a cloud server platform, and they suggested that this might be the issue.

[yenfryherrerafeliz]

edit: issue not related

[yenfryherrerafeliz]

Adding a needs-review label in order to address this further.
Here are some references of circular dependencies, specifically when installing @aws-sdk/client-s3:

Package: @aws-sdk/credential-provider-ini

• resolveProfileData -> resolveAssumeRoleCredentials

Package: @aws-sdk/util-endpoints

• callFunction -> evaluateExpression
• getEndpointProperties -> getEndpointProperty
• evaluateRules -> evaluateTreeRule

Thanks!

[rolanday]

+1, seeing many circ dep warning in SolidStart (uses Vite for build), and several of AWS client packages have this issue (not just S3). Given rapid esm adoption and frameworks using Vite, suggest AWS SDK run some hygiene tests on kits so not relying on customers to find issues that can be found / fixed by AWS team.