Skip to content

test(eventstream-handler-node): fix test broken in Node14 #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 1, 2020
Merged

test(eventstream-handler-node): fix test broken in Node14 #1221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb5ba6d
test(eventstream-handler-node): fix test broken in Node14
AllanZhengYP May 29, 2020
61a1eea
test(eventstream-handler-node): fix test in Node14
AllanZhengYP Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions packages/eventstream-handler-node/src/EventStreamPayloadHandler.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ describe("EventStreamPayloadHandler", () => {
).rejects.toThrow("Eventstream payload must be a Readable stream.");
});

it("should close the request payload if downstream middleware throws", async () => {
it("should close the request payload if downstream middleware throws", async done => {
expect.assertions(2);
(mockNextHandler as any).mockImplementationOnce(() =>
Promise.reject(new Error())
);
Expand All @@ -61,9 +62,11 @@ describe("EventStreamPayloadHandler", () => {
expect(error instanceof Error).toBe(true);
//Expect stream is closed
//Ref: should use writableEnded when bumped to Node 13+
expect(() => {
mockRequest.body.write("");
}).toThrowError("write after end");
(mockRequest.body as PassThrough).on("error", err => {
expect(err.message).toEqual("write after end");
done();
});
mockRequest.body.write("This should be allowed to write.");
});

it("should call event signer with request signature from signing middleware", async () => {
Expand Down