Skip to content

chore: convert second param in StandardRetryStrategy to options #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2020
Merged

chore: convert second param in StandardRetryStrategy to options #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/middleware-retry/src/defaultStrategy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,26 @@ export interface DelayDecider {
(delayBase: number, attempts: number): number;
}

/**
* Strategy options to be passed to StandardRetryStrategy
*/
export interface StandardRetryStrategyOptions {
retryDecider?: RetryDecider;
delayDecider?: DelayDecider;
}

export class StandardRetryStrategy implements RetryStrategy {
private retryDecider: RetryDecider;
private delayDecider: DelayDecider;

constructor(
public readonly maxAttempts: number,
private retryDecider: RetryDecider = defaultRetryDecider,
private delayDecider: DelayDecider = defaultDelayDecider
) {}
options?: StandardRetryStrategyOptions
) {
this.retryDecider = options?.retryDecider ?? defaultRetryDecider;
this.delayDecider = options?.delayDecider ?? defaultDelayDecider;
}

private shouldRetry(error: SdkError, attempts: number) {
return attempts < this.maxAttempts && this.retryDecider(error);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/middleware-retry/src/index.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ describe("retryMiddleware", () => {
"defaultDelayDecider"
);
const retryDecider: RetryDecider = (error: SdkError) => true;
const strategy = new StandardRetryStrategy(maxAttempts, retryDecider);
const strategy = new StandardRetryStrategy(maxAttempts, { retryDecider });
const retryHandler = retryMiddleware({
maxAttempts,
retryStrategy: strategy
Expand Down