Skip to content

example config to be propagated across packages #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

example config to be propagated across packages #1279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94430f1
example config to be propagated across packages
alexforsyth Jun 16, 2020
00d2db4
update
alexforsyth Jun 16, 2020
b1f627a
update
alexforsyth Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions packages/abort-controller/tsconfig.json
View file
Open in desktop

This file was deleted.

9 changes: 2 additions & 7 deletions packages/abort-controller/tsconfig.test.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
{
"extends": "./tsconfig.json",
"extends": "../../tsconfig.json",
"compilerOptions": {
"sourceMap": false,
"inlineSourceMap": true,
"inlineSources": true,
"rootDir": "./src",
"outDir": "./build",
"incremental": true
"outDir": "./build"
}
}
32 changes: 32 additions & 0 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"compilerOptions": {
/**
* Must allow:
*/
"downlevelIteration": true,
"resolveJsonModule": true,
"experimentalDecorators": true,
"noUnusedParameters": false,
"removeComments": false,

/**
* Nice to have:
*/
// "preserveConstEnums": true,
// "declaration": true,
// "allowUnreachableCode": false,
// "pretty": true,

"module": "commonjs",
"moduleResolution": "node",
"target": "es5",
Copy link
Member

@trivikr trivikr Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target should be browser TSConfig target, as that's usually the lower version of ECMAScript.

"lib": ["es2015", "dom"],
Copy link
Member

@trivikr trivikr Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decided to exclude lib, as it's overridden in individual clients

"baseUrl": ".",
"paths": {
"@aws-sdk/*": ["packages/*/src"],
"@aws-sdk/clients-*": ["clients/clients-*/"]
}
},
"include": ["packages/"],
"exclude": ["node_modules/", "packages/*/build/"]
}