Skip to content

Conversation

@AllanZhengYP
Copy link
Contributor

Description of changes:
Add a command yarn local-release to release ALL the package locally. All the packages will be released as 1.0.0-ci.0 version.

This change is required for end2end test where the test script will mimic installing the packages from npm local registry that released by the command above.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020

Codecov Report

Merging #1308 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1308   +/-   ##
=======================================
  Coverage   77.49%   77.49%           
=======================================
  Files         286      286           
  Lines       11899    11899           
  Branches     2600     2600           
=======================================
  Hits         9221     9221           
  Misses       2678     2678           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8dd3da...04585d0. Read the comment docs.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review June 30, 2020 00:23
@AllanZhengYP AllanZhengYP force-pushed the AllanFly120/local-release branch from 7c64e7b to 6dfc2c6 Compare June 30, 2020 22:00
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we need tests for this? I think not since its just a local publish script, but would I like to weigh that

@AllanZhengYP
Copy link
Contributor Author

@alexforsyth I don't think we need because it has nothing to do with the code we ship to the users. This script helps us doing end-to-end test by fully mimicing the users' behavior from installing the SDK.

@AllanZhengYP AllanZhengYP merged commit 85866ff into master Jul 1, 2020
@AllanZhengYP AllanZhengYP deleted the AllanFly120/local-release branch July 1, 2020 20:44
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants